search

nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Diagram missing visibility #1478

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Filter class diagram did not include visibility of the fields and methods. Visibility should be shown to allow the developer a better understanding of the underlying implementation.

Screenshot 2022-04-16 at 3.24.58 PM.png

This is inconsistent with the class diagram in edit feature that showcases the visibility

[original: nus-cs2103-AY2122S2/pe-interim#1477] [original labels: severity.Medium type.DocumentationBug]

alexteo98 commented 2 years ago

Team's Response

Visibility can be omitted as they are optional.

Duplicate status (if any):

--