search

nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Tags can be piped #1538

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Expected: Tags should not contain special characters when adding or editing. Actual: When i use '|' on tags for edit and add, it pipes the tag instead into two tags

Steps to reproduce: add -n xxxx-d 15 -ss 1 -i spaghetti 56 grams | garlic 3 cloves| bacon 3 slices | olive oil 110 ml -s Cook the spaghetti until aldante | Saute the chopped garlic | Toss spaghetti in the sauce |taste and season with salt and black pepper -t Asi|an

image.png

[original: nus-cs2103-AY2122S2/pe-interim#1543] [original labels: severity.Low type.FunctionalityBug]

Oddcorner commented 2 years ago

Team's Response

The assumption that tags cannot be piped is false. Here is a screenshot of our UG (page 4) that states:

image.png

Since [-t tags separated by pipe] was explicitly stated, the input Asi|an being parsed as two separate tags Asi and an is the expected behaviour.

Furthermore the concern that add allows for "special characters" in tags is also not true, as running add -n boiled egg -d 7 -ss 1 -s boil the egg -i egg 1 -t sim&ple results in the following error:

image.png

Since no functionality bug is observed, our team has decided to reject this bug.

Duplicate status (if any):

--