nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

addorder doesn't take into account alphabet cases. #2048

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

When adding an order, alphabetical cases are not considered. The error thrown is "Some of the dishes provided does not match any of the existing dishes. Please first create the dish.", which to user will not make sense because say "Kimchi" is entered and the menu shows "kimchi" user will be puzzled why it is not being processed and will try to add another dish call "kimchi" which will also not processed because of duplicate dish name. Worse case, user do not know where he made the mistake and the order cannot be created.

Screenshot 2022-04-16 at 2.35.53 PM.png


[original: nus-cs2103-AY2122S2/pe-interim#2067] [original labels: type.FunctionalityBug severity.Medium]

xzzz3 commented 2 years ago

Team's Response

We believe that this is a low severity bug, as this is unlikely to affect normal operations. It was not mentioned in the UG that addorder takes in case-insensitive dishes, and thus it should not be assumed that case-insensitive input is accepted. The user should stick to case-sensitive input unless specified otherwise, and in the screenshot you provided, the user can easily see that there is a case-sensitivity issue. It only causes minor inconvenience for users to go to the dish tab and check the capitalization in the case where they do not recall what they keyed in during dish creation.

Duplicate status (if any):

--