Order information not updated when Dish name is changed

[nus-pe-bot]

Steps to Reproduce

1) Add a new order that is tagged to Alex Yeoh's phone number and the dish (Fries and Chicken Nuggets) using this command addorder p/98765432 d/Fries, Chicken Nuggets.

2) Switch to Dishes tab using the command listdish and edit the name of chicken nugget to fish nugget using the command editdish 3 n/Fish Nugget.

3) Switch back to the Orders tab using the command listorder all and you would notice that the name Chicken Nugget is not changed as shown below.

I should expect the order details to change if the dish name is edited.

---

_{[original: nus-cs2103-AY2122S2/pe-interim#2164] [original labels: type.FunctionalityBug severity.Medium]}

[xzzz3]

Team's Response

Hello tester, thanks for testing our app! The issue you mentioned is that the dish names do not change in the orders when they are edited after the order is created. This is an intended and important behavior for our app to serve its purpose for the target audience. Consider this: Previously, the restaurant sold french fries, and some orders were created with french fries as a dish. Later on, the manager thinks that twister fries are more profitable, thus started selling twister fries and edited the dish to twister fries. The old orders should then still have their dish as french fries, while the newer orders should have twister fries. It does not make sense that once the menu is updated, all the old (and already done) orders' dishes change with them. Same goes for dish prices, where if the prices of the dishes go up after a menu revamp, the previous orders that are already created should not have a price increase (the manager can't go and chase customers to tell them to pay more!). Since one of the main reasons users would keep old orders in the app is for record keeping, it is important that the old records stay as they are, so that record keeping can be done effectively. Changing this may make our app less usable and desirable.

As a result, we propose rejecting this issue. Thanks!

Duplicate status (if any):

--