Order information not updated when customer phone number is edited.

[nus-pe-bot]

Steps to Reproduce

1) Edit the phone number of Charlotte Oliverio from 88887777 to 97778888 using this command editcustomer 3 p/97778888.

2) Switch back to the Orders tab using the command listorder all and you would notice that the phone number is not changed as shown below.

I should expect the order details (phone number) to change if the phone number is edited.

---

_{[original: nus-cs2103-AY2122S2/pe-interim#2165] [original labels: type.FunctionalityBug severity.Medium]}

[xzzz3]

Team's Response

Hello tester! Thank you for testing our app. The "issue" you mentioned is that after changing a customer's phone number, the customers' old orders do not reflect the details change. This is actually an intended and crucial behaviour with our target audience (restaurant delivery managers) in mind. I will use an example of changing a customer's address in the app to illustrate this as it is easier to see the rationale, but the same goes for changing their phone number. Consider this: a customer Aaron moved recently from Changi to Jurong. In the restaurants' record, the old orders to Aaron's old house should still have the address as the Changi address, and the new orders in Jurong should have the Jurong address after editing Aaron's address to become Jurong. It does not make sense that all the old order suddenly changes to Jurong, since they were not delivered there! The same goes for changing phones and names, which are also customer attributes. One of the main reasons the users would want to keep the old orders in the app would be for record-keeping, and this cannot be achieved if the old orders' details keep updating with new changes that do not affect them (since they already happened). Therefore, this is an expected behaviour and changing it may cause the app to be less desirable and usable for our target audience.

As a result, we propose to reject this issue. Thanks!

Duplicate status (if any):

--