search

nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Able to add two people who have similar names into the app. #2220

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Step to reproduce:

  1. Type addstudent -n sammy_ _ _ _ _ _ boyo -p 904020041 and addstudent -n sammy _ boyo -p 904020041 where "_" is a whitespace character.

  2. Both people can be added to the app as shown in the image below.

image.png

Expected: App to reject the adding of that person because both of them are the same person semantically. The amount of whitespace between the words is not supposed to distinguish them as two separate people.

Actual: The app recognizes them as two different people.

[original: nus-cs2103-AY2122S2/pe-interim#2243] [original labels: severity.Low type.FeatureFlaw]

nnmoq commented 2 years ago

Team's Response

Yes, we agree that whitespace should not be used to distinguish names.

Duplicate status (if any):

--