nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Price should not have arbitrary limit #2535

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

To replicate: add a product with price more than 999999.99

Current result: get the following error message: "Prices should only have at most two decimal places, non-negative and at most 999999.99".

Intended result: Should instead accept the price as valid and add the product to the iBook, as some shopkeepers that sell expensive goods (e.g. kitchen renovation packages, etc.) which may cost higher than 999999.99, which is an arbitrary limit for price anyway. This makes them unable to use the product in such an event.


[original: nus-cs2103-AY2122S2/pe-interim#2572] [original labels: severity.Medium type.FeatureFlaw]

DavidTan0527 commented 2 years ago

Team's Response

We believe that 999999 is a very high price for a product and thus is sufficient for all use cases. As we are targeting small-scale grocery storekeepers, we believe it is highly unlikely for them to sell anything that costs above 999999.

For your information, an average HDB in Singapore is around $500k, which is still way below our limit. We question the existence of a single product in a small-scale grocery store having a price of over $1mil for our target users.

Further extending from your example, a kitchen renovation package costing more than the house itself remains questionable to our team. Besides, do small-scale grocery stores sell kitchen renovation packages anyway...

Therefore, with much careful consideration, we will be rejecting this issue.

Duplicate status (if any):

--