nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Long candidate names will be cut off and does not wrap #3212

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Details

Application does not wrap people names that are long (shown in screenshot #1). This can be an issue as there are some names who are really long. Although the app has a functionality to expand the focus area but even so with a longer name, the name will still get cut off (shown in screenshot #2). My suggestion for the solution is to wrap the names of the candidates in the UI.

Command (example command to test)

edit 1 n/Christopher Lang Wee Kiat Oliveiro Roy Balakrishnan John Doe edit 1 n/This is to simulate a very long candidate name that can pose an issue to the application due to it being very long and causes the name to be cut off

Screenshots

image.png

image.png


[original: nus-cs2103-AY2122S2/pe-interim#3274] [original labels: severity.Low type.FunctionalityBug]

charmainehly commented 2 years ago

Team's Response

Our team has rejected this as not a bug reason being that in the earlier phases, we have deemed that the nature of our application does not prioritise nor necessitate the legal full name of a candidate to be inputted for functionality. The name is simply an identifier for the prof, and it is at the prof's discretion to shorten and only keep the first name or part of an extremely long name for the interview scheduling and for convenience. The focus is instead on the unique email, studentid and phone which identifies a candidate and allows for contacting the candidates.

Other design considerations that involve wrapping the name (as suggested by the tester) is not deemed suitable (and considered a suboptimal design) because it would then hinder the user's view of more pertinent information like the interview/application status, as well as studentid. course and seniority details in the candidates list/candidate profile panel. Instead the team has already addressed this by allowing some flexibility in resizing the panels to allow better viewing of longer names if really needed.

Currently, the default window size for the candidates list and focus panel allows for a considerable number of characters shown (see first screenshot below) of up to about 30 characters (or even more) in the candidates display. Likewise for the focus panel (see second screenshot below), a simple resizing of the focus panel which has been implemented by the team also reveals the full long name inputted (with room for more characters as the tester has also determined). In addition, extremely long names could further be deemed as extreme user inputs which is also not accepted as a bug.

image.png

image.png

Hope this clarifies.

Duplicate status (if any):

--