nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

Program allows duplicate phone numbers to be saved. #3535

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Screenshot 2022-04-16 at 2.40.51 PM.png

Description: Attempted to save the edit the phone numbers of the patrons to be the same.

Step to reproduce: patron edit 1 p/39393944445555666666 patron edit 2 p/39393944445555666666

Expected: Error message stating phone number has already been saved to another patron.

Actual: Program allowed different patrons to have same phone number.


[original: nus-cs2103-AY2122S2/pe-interim#3502] [original labels: severity.Low type.FunctionalityBug]

bingsen0806 commented 2 years ago

Team's Response

This is not a functionality bug because its behavior is specified in our User Guide, and is expected. In the User Guide below, we specified that only name, email and id cannot have duplicates, but deliberately did not mention phone number.

image.png

image.png

This is also not a feature flaw. The rationale for allowing multiple phone numbers is because it is possible for two patrons to have the same phone number (can be either mobile or home number). Household phone numbers of siblings are often the same, and in some uncommon cases some siblings also share phone numbers.

Duplicate status (if any):

--