nus-cs2103-AY2122S2 / pe-dev-response

0 stars 0 forks source link

No restrictions on length of phone number #415

Open nus-se-bot opened 2 years ago

nus-se-bot commented 2 years ago

For a contact management system, it might be good to restrict the length of phone numbers to the maximum length. I believe the international standard for maximum digits is 15?

image.png

In this case, you can add a person's contact with no cap on the length of the phone number.


[original: nus-cs2103-AY2122S2/pe-interim#288] [original labels: severity.Low type.FeatureFlaw]

Punpun1643 commented 2 years ago

Team's Response

Dear tester,

Firstly, I don't see a problem with accepting a long phone number as in this case it is likely the event that it is deliberate sabotage.

Secondly, this extreme phone number input actually shows that the app is still able to work fine even with such an extreme input. (i.e. such input does not cause the app to crash or make it unusable)

Thirdly, the acceptance of extreme phone numbers does not hinder the ability of normal users who would input normal phone numbers as an input. Hence, I don't see the problem here.

Lastly, based on the module policy I do not think that this could be considered a bug as it is an extreme user behaviour:

7F16EFC6-D839-41B3-8DA5-4DC74E35FD7C_4_5005_c.jpeg

Duplicate status (if any):

--