search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Case insensitive duplicate detection system #1099

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Duplicate detection failure, 7.John Doe, 8.John doe and 9.John Doe likely to be the same person

Screenshot 2022-11-11 at 4.18.33 PM.png

image.png

Steps to reproduce:

addc n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney m/CS1101S m/ES2660 gh/JohnnyDodo tele/JDo

addc n/John doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney m/CS1101S m/ES2660 gh/JohnnyDodo tele/JDo

addc n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney m/CS1101S m/ES2660 gh/JohnnyDodo tele/JDo

[original: nus-cs2103-AY2223S1/pe-interim#933] [original labels: type.FeatureFlaw severity.Low]

JonLamy commented 2 years ago

Team's Response

It is probably better to have a warning for cases like this in future iterations. For this iteration, the team decided that they can only be sure that two names are duplicates if they match exactly. If two names differ slightly, the app cannot know if it was intentional or not, so it will take the safer route of allowing it as it does not significantly impact the performance.

Duplicate status (if any):

--