nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

add student bug - duplicate name checking #1670

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

image.png

Error message for same student name.

image.png

Command accepted for same student name in different case.

Steps to reproduce:

Enter the commands:

add n/John Doe p/98765432 e/johnd@example.com a/Prince George Park Residence 4 c/CS1101S c/CS1231S

add n/John doe p/98765432 e/johnd@example.com a/Prince George Park Residence 4 c/CS1101S c/CS1231S

Duplicate name checking is reasonable to have, but this behavior where accepting the same name in a different case does not seem intuitive or consistent with how one would keep track of a unique list of names usually. In particular, when I have a student called "John Doe" already in the list, the command to add another student with the exact same name "John Doe" is rejected as expected, but if I replace "John Doe" with "John doe", the command is accepted.


[original: nus-cs2103-AY2223S1/pe-interim#1419] [original labels: type.FeatureFlaw severity.Low]

njxue commented 1 year ago

Team's Response

No details provided by team.

Duplicate status (if any):

Duplicate of #851