search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Bugs related to duplicate person detection #200

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Steps to reproduce:

  1. Enter prof n/Koro Sensei m/CS3230 p/98663357 e/KoroSensei@gmail.com g/M t/wantedgi t/senseikoro r/5 in the command box.

image.png

  1. Enter prof n/Koro sensei m/CS3230 p/98663357 e/KoroSensei@gmail.com g/M t/wantedgi t/senseikoro r/5 in the command box, this time with a small letter s in the name.

image.png

  1. Since the app has actually detects duplicated person, By looking at the result, it's very obvious these two are the same person just a different case in the name, this leaves some potential duplicate person cases to be undetected. Could add more checks rather than just comparing name to detect duplicate person.

image.png

[original: nus-cs2103-AY2223S1/pe-interim#258] [original labels: type.FeatureFlaw severity.Low]

Jonaspng commented 1 year ago

Team's Response

It is written in the user guide that namse are case-sensitive. Hence, same name but different case are deem as different people by the application. Thus, the application would deem the Koro Sensei and koro sensei are 2 different persons and hence update the pie chart.

Furthermore, these extra checks you mentioned are considered as not in scope as they are additional features.

image.png

Duplicate status (if any):

--