nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

verifying phone number length #2040

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

In the ug it is stated that SoCompiler is currently optimised for SOC students, and thus we assume that everyone will have Singapore numbers.

With this in mind, the application should then be able to check the length of the phone numbers that will be added as being able to add a number with <8 numbers might be a flaw

However this might mean that foreign numbers cannot be added, which is why I classify it as a very low severity feature flaw

Steps to replicate


[original: nus-cs2103-AY2223S1/pe-interim#2648] [original labels: type.FeatureFlaw severity.VeryLow]

therealdaofu commented 2 years ago

Team's Response

This is a design choice not to limit the length of a phone number. As stated in the FAQ section of our UG, we gave users the flexibility to still add in foreign numbers (including country code, just not the '+'). Therefore, we would not be able to limit the phone number to 8 numbers.

image.png

Duplicate status (if any):

--