search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Overzealous input validation for name of supplier #2110

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago
  1. Attempt to add a supplier of name: Amy's Pet House
  2. Error message thrown and input blocked.

image.png

A pet supplier's name might use the " ' " symbol. This hinders operation of software and causes inconvinience to the user. This may happen relatively often but users can still use the product

[original: nus-cs2103-AY2223S1/pe-interim#2736] [original labels: type.FeatureFlaw severity.Medium]

wweqg commented 1 year ago

Team's Response

Hi,

Thank you for your suggestion. We accept this as a bug.

However, we think that this bug should be of low severity because not too many pet suppliers' names contain special characters. Our target users's suppliers will be mainly individuals whose names are more like "Amy Smith", "Bernice Yu", "Ben Hong" etc. Therefore, the normal usage is highly unlikely to be affected.

This is a duplicate of another issue because they are all about overzealous input validation on names.

Duplicate status (if any):

Duplicate of #2585