search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

BUG: Name can contain numbers #2197

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Describe the bug
:

When adding a new person, names that contain numbers or are just numbers are allowed. This is a flaw as names do not contain numbers

To Reproduce
:

Add a new person with numbers for names example: add n/1456 p/98765432 e/johnd@example.com nok/Jane Doe, Wife, 82858285 pt/inpatient hw/south fn/3 wn/D690 m/panadol m/ibuprofen

Expected behavior
: possibly an error message to restrict the adding of this person

Actual behaviour: person with number for name will be added Screenshots/Videos
: Screenshot 2022-11-11 at 4.15.24 PM.png

[original: nus-cs2103-AY2223S1/pe-interim#1840] [original labels: type.FeatureFlaw severity.Low]

nehcuy commented 2 years ago

Team's Response

As mentioned in this website, it is possible for names of people to contain numbers.

An example of a person with the number 8 in her name is here.

Furthermore, we have chosen to avoid overzealous input validation in this case as clinics may wish to add further labeling to the patient's names.

It would be highly improbable for a user to accidentally replace the patient's whole name with numbers and hence we do not believe that this is an issue.

Duplicate status (if any):

--