search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Buyers that do not have a specified price passes the filter #2263

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Screenshot 2022-11-11 at 4.56.06 PM.png

Issue

Even though price range is stated as an optional field in the UG, it shows up as Non-Specified in the application. The specifications of the filterbuyers command was phrased such that only when buyers fulfil all the specified filters will it appear in the filtered list. However, when i use the command to filter for only price, all the buyers with no specified price ranges appear, which contradicts the intended implementation specified by the UG.

Steps to reproduce

  1. Add some buyers without a specified price
  2. Type the command filterbuyers -p 300000
  3. Observe that these buyers are also displayed

Suggestion

  1. Make it such that the buyers with no valid price are do not pass the filter and are not displayed in the application (potentially works better for the intended usage by the target users). OR
  2. Specify in the UG that buyers with Non-specified price range will pass the filterbuyers -p filter.

[original: nus-cs2103-AY2223S1/pe-interim#2946] [original labels: severity.Medium type.FunctionalityBug]

riccqi commented 2 years ago

Team's Response

We intended the filter commands to give more suggestions that may still fit the filter since the price range is unknown, but we agree that it was not specified correctly in our user guide. It makes sense that buyers without a price range are still shown, as logically it means that they do not have a preference for budget.

The buyer with "not specified" price range will only appear at the end of the buyer list, and the correct buyers will still appear at the top. Hence we believe it is just a minor inconvenience, and thus a low severity bug that can be clarified with a UG change.

Duplicate status (if any):

--