search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

[DG] Model Class diagram multiplicity #2584

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

From your UG, it states that the following are optional:

As such, there should be a multiplicity of 0..1.

But your model class diagram insinuates that it is compulsory for these fields to hold a value, when they could be null.

image.png

Therefore, the multiplicity for some of them should be update to 0..1.

[original: nus-cs2103-AY2223S1/pe-interim#2184] [original labels: type.DocumentationBug severity.Low]

kevinchangjk commented 1 year ago

Team's Response

Hi there! Thanks so much for the report.

If you look at our implementation of the Person class, when email, address and phone is not added, they are still initialised and composed as static objects with placeholder value of N/A. Hence, the multiplicity of this will still be 1. Hence we are rejecting this bug.

Once again, thank you so much for informing us regarding the error.

Cheers,
Coydir
HR is hard, Coydir is easy
(est. 2022)

Duplicate status (if any):

--