nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Edit command allows us to edit with a duplicate with no warning/error #2614

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

For example, I am allowed to edit the name Hongyi to Hongyi again. This is quite improbable in real life usage. No warnings was given when this happens.

A warning/error would be helpful to the user to let them know they are keying in a duplicate

image.png

image.png


[original: nus-cs2103-AY2223S1/pe-interim#2206] [original labels: type.FunctionalityBug severity.Low]

wweqg commented 1 year ago

Team's Response

Dear Tester,

Thank you for your report. However, we don't quite understand the issue here. When a user edits their contact to have the exact same field input as before, there are no duplicate contacts created and the edited contact will remain the same as before. A contact will only be counted as a duplicate if their names, their emails, and their person category are the same. This is stated under the FAQ section in our user guide (please see the following screenshot below).

Screenshot 2022-11-14 at 2.03.37 PM.png

The following screenshot demonstrate that when the user is trying to edit a person's contact to have the same name and same email as someone else in the address book, there will be an error message thrown to show that this person already exists in the address book.

Screenshot 2022-11-14 at 2.02.55 PM.png

Thank you!

Duplicate status (if any):

--