nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Overzealous input validation for phone number of client #2992

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

There might be international residents, or even residents who are holding international phone number. However, the application does not allow the input of phone numbers with extensions, such as +606 95858447, but only allow a total of 8 digits in phone number. This might be very restricting and there is no point to restrict such a field.

Steps to replicate:

Execute the command add n/Betsy Crowe t/friend e/betsycrowe@example.com r/2-3 p/+65 12345678 m/A3456789B g/F h/A

Expected result: New resident added

Actual Result: Adding of such a resident is blocked, and require the phone number to be of length 8, which is very inconvenient for cases like that.

image.png


[original: nus-cs2103-AY2223S1/pe-interim#2521] [original labels: type.FeatureFlaw severity.Low]

nealetham commented 1 year ago

Team's Response

Both issues relate to the input validation of phone numbers.

Duplicate status (if any):

Duplicate of #2386