nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

The generation of certain exercises does not make sense. #3016

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Since push ups and treadmill are valid exercises for users at a gym, the generation command does not provide a suitable number for the user since it is only catered towards exercises that have weights, sets and reps associated with it. This would be not very useful for the user if the user wanted to improve their cardio by seeing recommendations of increased weights for the treadmill.

2.png

3.png


[original: nus-cs2103-AY2223S1/pe-interim#2547] [original labels: type.FeatureFlaw severity.Low]

ErvinK123 commented 1 year ago

Team's Response

Hi there! Thank you for your report.

We are accepting this issue as a severity.Low Documentation Bug because:

  1. Firstly for the push-up and treadmill exercises that you mentioned, both CAN have weights associated with them. As explicitly mentioned in our glossary, the 'weight' field refers the total weight of the equipment used.

Screenshot 2022-11-14 at 3.59.04 PM.png

Please refer to these images to show how push-ups and treadmill exercises can be deemed as weighted.

weighted-pushup.gif

photo_2022-11-14 18.13.32.jpeg

photo_2022-11-14 18.14.02.jpeg

  1. Secondly, as mentioned in our DG, exercises that you add as a user are in your own discretion. Hence as a user, if you had deemed the weight/set/rep fields of such exercises as inappropriate, then perhaps it would not have made sense to add these exercises into the database in the first place, let alone try to execute a 'generate' on these exercises.

Screenshot 2022-11-14 at 4.06.23 PM.png

  1. However, my team and I will concede that the exercise definition in our glossary is insufficiently scoped, as Gim is in actuality optimised for weightlifting exercises.

We recognise that your misconception came about due to the poor phrasing of our exercise definition, and hence we will be classify this as a Documentation Bug and we sincerely apologise for the confusion.

Thank you once again for your report.

Gim

Duplicate status (if any):

--