search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Changing the GitHub username manually in `addressbook.json` results in wrong user being loaded #309

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Description

By manually editing the github username in the data file, a user will expected the contact to be fully updated with the new user's profile picture and repositories etc. However upon testing only the profile picture and repositories are updated, while the name (along with location) remains the same

Testing process

  1. add github/h
  2. Edit github username of h -> hee
  3. Reopen the application
  4. New profile pic and repos are updated but name and location still stays the same

image.png

@hee should have a name of hidemail instead of Samuel Hoffstaetter

[original: nus-cs2103-AY2223S1/pe-interim#395] [original labels: severity.Medium type.FunctionalityBug]

arnav-ag commented 1 year ago

Team's Response

This is because the name and location are already specified in the save file, and we will not override any user-set parameters. This is a feature, not a bug.

Duplicate status (if any):

--