nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Phone Number Input Validation Feature Flaw #3158

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Since the application is targeted to NUS students, the phone number field being allowed to be any length above 3 might be a feature flaw. Although UG states that it allows 3 digits for emergency numbers, being a task management app for NUS students, this may not be applicable. Also, allowing 4,5,6 digits may not be applicable due to the reason stated below.

image.png

Since the international standard for phone numbers is between 7 and 15 numbers, allowing phone numbers greater than 15 and less than 7 would not be necessary.


[original: nus-cs2103-AY2223S1/pe-interim#2676] [original labels: type.FeatureFlaw severity.Low]

seetohjinwei commented 1 year ago

Team's Response

We have added relevant validation and restrictions to reject user inputs that are not phone numbers, i.e. non-integer and lesser than 3 numbers.

image.png

image.png

Further validation of phone number is up to the user's discretion, it is not in the scope of the project to justify what exactly constitutes a phone number and what does not.

Duplicate status (if any):

--