search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

7 digit phone number accepted #3338

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Screenshot 2022-11-11 at 4.22.45 PM.png

Issue

A phone number that has only 7 digits was able to be accepted added to the buyer's contact. This is a functionality bug because when using Cobb to get this buyer's contact in the future, the information could be incorrect without the user knowing. Although not many users will encounter this erroneous input, it will be a problem for certain errors, therefore it is a low severity functionality bug.

Steps to reproduce

  1. Enter addbuyer -n abcd -ph 1234567 -e hihi@gmail.com -a s123456 into the command line.
  2. The buyer is added into the application.

Suggestion

Check through the user's input and ensure that the phone number is a valid phone number (starts with 6,8,9 and has 8 digits)

[original: nus-cs2103-AY2223S1/pe-interim#2940] [original labels: type.FunctionalityBug severity.Low]

zsiggg commented 1 year ago

Team's Response

It is possible for a phone number to be 7 digits.

Duplicate status (if any):

--