nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Add person to module feature bug #3609

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Bug Description:

The list of persons currently displayed in the home page includes person Charlotte Oliveiro

After navigating to module CS2106 with goto CS2106

Then running the command add-person-to-module m/CS2106 n/Charlotte Oliveiro

Expected:

Added person Charlotte Oliveiro under module CS2106

Actual:

It shows that there is no such person in the list, hence i would have to navigate back to the home page and type it again

image.png


[original: nus-cs2103-AY2223S1/pe-interim#3357] [original labels: type.FunctionalityBug severity.Low]

cheeheng commented 1 year ago

Team's Response

We feel that this is a feature flaw rather than functionality bug. This is because this is a design consideration that we made, and we also explicitly mentioned it in our UG.

goto CS2106 filters the person list as well as the module list such that the module list shows only CS2106 and the person list shows only the people currently added to CS2106, which excludes Charlotte Oliveiro. See the user guide snippet below:

image.png

Then add-person-to-module finds that Charlotte Oliveiro is not currently displayed in the persons list, hence throwing the error message. See the user guide snippet below:

image.png

Thus, this is not a case whereby the functionality fails to perform as expected, but more so a design decision.

The way the add-person-to-module command is designed leads to less convenience to the user because the user can only add what he/she can see. Your example states one way the inconvenience arises. There is an alternative to goto, which is find-module, but this command does not solve the problem because the user might want to see who is currently added to the module, while find-module does not filter people by who is currently added to the module.

Duplicate status (if any):

--