nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Inconsistent error message when finding suppliers #3850

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Screenshot 2022-11-11 at 5.07.36 PM.png Screenshot 2022-11-11 at 5.07.36 PM

When executing find n/ hello to find a supplier with hello in the name, the error message instead refers to the found suppliers as 'persons'.

This is inconsistent and can be confusing for users, especially since the listSuppliers command refers to them as suppliers, not persons. Screenshot 2022-11-11 at 5.09.06 PM.png

I would expect all reference to suppliers to show "suppliers" instead of the default AB3 persons.


[original: nus-cs2103-AY2223S1/pe-interim#3698] [original labels: severity.Medium type.FunctionalityBug]

weesiau commented 1 year ago

Team's Response

I agree that all reference to suppliers should show "suppliers" instead of "persons". However, it is a typo and purely cosmetic issue in the UI and it does not affect the normal operations of the application usage at all. Hence I propose that the original severity of medium is too high and change it to veryLow.

Duplicate status (if any):

--