search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

deletion and update anomaly after deleting module #4464

Open nus-pe-bot opened 2 years ago

nus-pe-bot commented 2 years ago

Steps to reproduce the error:

  1. mlist
  2. mdel c/cs1101s
  3. list

Expected: Tag relating to the deleted module cs1101s should be removed as the module no longer exists.

Actual: The tags remains.

Similarly, this can be linked to edit action. When a module's code gets edited eg cs2030s -> cs2031s, tags that include contents beyond merely the module code do not get updated accordingly.

Screenshots:

image.png

image.png

image.png

[original: nus-cs2103-AY2223S1/pe-interim#4557] [original labels: type.FeatureFlaw severity.Low]

leongdl135 commented 2 years ago

Team's Response

Thanks for your concern, however, this is not a feature flaw, but rather an intended feature.

For our implementation, the class group is a standalone feature as compared to the modulecodes etc. The intended use was the the Professor to make use of the class groups feature for his own purposes. For example, he could name is tut01 - 2030 or CS2030S - tut01. Both convey the same message. However, if we were to delete the classgroups when the module gets deleted, it would be hard to determine which class group to delete. Additionally, the Professor might want to keep track of the class group of the students he taught last sem in case he wants to hire TA's in the future for a related module.

Additionally, it is also written that the class group will not be deleted and there are no restrictions on the things added.

image.png

As there are many things to consider, we decided to leave class groups as a standalone feature that is not dependent on the Module Manager features. This, this is not a feature flaw, but an intended outcome.

Duplicate status (if any):

--