nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Overzealous input validation #4862

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

image.png

The restriction of phone number format seems to be overly restrictive, as the User Guide did not mention where exactly the target users may be staying. A lot of other countries have phone numbers that exceed (or are shorter than) 8 digits. Even in Singapore alone, since the app is supposed to manage contacts of students; a number of students may only have international numbers (e.g. if they just came to Singapore and have not gotten a local number yet).

Let alone the NOKs of these international students which may not even reside in Singapore at all.


[original: nus-cs2103-AY2223S1/pe-interim#5078] [original labels: type.FeatureFlaw severity.Medium]

seanflyyy commented 1 year ago

Team's Response

They both point out the restrictive nature of our validation for the phone number.

Duplicate status (if any):

Duplicate of #5102