search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

[DG] Diagram for Model groups multiplicity and #5164

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Issue

There is a *all and *filtered near the Person class which is a little confusing

image.png

I can still understand the diagram after thinking about it for a while (initially I thought it was a note but afterwards I realised that it was multiplicity + association role) so I can consider this a purely cosmetic issue.

Suggestion

Separate them by a new line instead of having them all on one line

[original: nus-cs2103-AY2223S1/pe-interim#5001] [original labels: severity.VeryLow type.DocumentationBug]

leecaregene commented 1 year ago

Team's Response

The class diagram follows standard UML notations, and should not hinder the reader. Notes have a different notation, and it does not make much sense for an association role to start with a *, so we believe there is little room for misinterpretation here.

Duplicate status (if any):

--