nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Duplicate detection limitation not clear in add command #5441

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

This input is valid, even though the name is only different by case:

image.png

But this is not valid, even though all the other information is different from the first Roy:

image.png

Citing from the module web: Bugs related to duplicate detection: Duplicate detection (e.g., detecting if two persons in the address book are the same) is not trivial; often, detecting only the exact string/value matches is not enough. For example, John Doe and john doe are likely to be the same person. Similarly, extra white space (e.g., the user typed an extra space between the two names) is unlikely to mean they are two different persons. Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision. If you app has a duplicate detection feature, make sure its limitations are made clear to the user so that users are not led to believe that duplicates are being detected while many potential duplicate cases go undetected. Otherwise, it can be considered a type.FeatureFlaw.

But the UG doesn't specify anything regarding this matter.


[original: nus-cs2103-AY2223S1/pe-interim#5269] [original labels: type.FeatureFlaw severity.Low]

darrentde commented 1 year ago

Team's Response

No details provided by team.

Duplicate status (if any):

--