search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

markAtt accepts invalid dates #5658

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

[How to reproduce]

Using the sample data, run markAtt d/32/6/2022 c/1.2 ind/2

[Expected]

Error is thrown since the date is not valid

[Actual]

No error is thrown

[original: nus-cs2103-AY2223S1/pe-interim#5590] [original labels: type.FeatureFlaw severity.Medium]

jgyj123 commented 1 year ago

Team's Response

Can we categorise this as "Problems caused by extreme user behaviours" under functionality bugs? Since user by right should not be inputting a invalid date. The app also doesn't crash or become unusable because of this.

User can go to data file and remove the wrong attendance from the student. But since this causes inconvenience but is very infrequent, perhaps can reduce the severity to low?

From website: Problems caused by extreme user behaviors: If the problems can only happen in case of deliberate sabotage (e.g., user entered a 30-digit telephone number), in which case it should not be considered a bug. However, if such input can be entered by a user mistake, they should not cause harm e.g., such mistakes should not crash the app, corrupt the data, or make it unusable. Problems caused by integer overflows -- apply the guideline in the previous point.

Duplicate status (if any):

--