nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Phone number minimal condition is not suitable #5660

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

The phone number field for candidates requires a minimum of 3 digits, which is not ideal. Ideally, it should be greater than 3 digits (e.g. Singapore's is 8 digits).


[original: nus-cs2103-AY2223S1/pe-interim#5592] [original labels: type.FeatureFlaw severity.Low]

pratham31012002 commented 1 year ago

Team's Response

According to https://en.wikipedia.org/wiki/N11_code, there are abbreviated 3 digit valid telephone numbers eg. 911. While this is unlikely to be used for normal recruiting needs, we made our application as accommodating as possible for all use cases.

Moreover, certain islands and territories like Saint Helena and Niue have 4 digit valid phone numbers.

Hence, we feel that 3 was the correct minimum number of digits for a phone number.

Duplicate status (if any):

--