gunbux
commented
1 year ago Team's Response
As a group, we do think this is a minor flaw. However, we as a team agree that:
-
A severity of high suggests this completely breaks something or has disastrous outcomes. We disagree on that since it's not really that common to use special characters in what you expect to be task descriptions or names aside from very specific workflows you mentioned like reviewing PRs
-
Given the current example, you could very easily just name it
task add tn/Review PR 2 i/Due ASAP d/12/12/2022. It feels like a mild inconvenience to the user, not something that significantly hinders any action
Duplicate status (if any):
--
Steps to Reproduce
Run
task add tn/Review PR #2 i/Due ASAP d/12/12/2022Expected
Task should be added. It is very common to want to have characters such as #, (, !, ), etc. in tasks and it is unreasonable for users to not be allowed to enter them in task names. For example, a TA for a software engineering module might want to look through a random PR of a group to make sure they're following the right instructions given by the instructors. Hence, the task name can be "Review PR#2", which is how GitHub and other applications refer to issues and PRs.
The problem is made worse by the fact that you cannot even enter parentheses (which is a very commonly used). Hence, it significantly hinders users from performing common actions.
Actual
[original: nus-cs2103-AY2223S1/pe-interim#5612] [original labels: type.FunctionalityBug severity.High]