nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

`addprop` valid name input rejected #5713

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Description: Cannot enter a valid name, even it matches requirement in error message

To reproduce:
Enter addprop -n thtr hhrth -p 8888888888888888888888888 -a aaaaaaaa aaaa aaaa -d faoejfoi aejfoijjjjjjjjjjjjeaaaaaaaaaaaaaaa aoeijffffffff -o owner 1 -ph 22002255

Expected: Property with name "thtr hhrth" added

Actual:

image.png


[original: nus-cs2103-AY2223S1/pe-interim#5673] [original labels: severity.Medium type.FunctionalityBug]

chngchngchng commented 1 year ago

Team's Response

The error message states that "Names can only be in English", which excludes numbers. In this case, the error is caused not because of "thtr hhrth", but rather is because the owner name is "Owner 1" which has a number inside. This behaviour is as expected.

Screenshot 2022-11-14 at 4.17.07 PM.png

As you can see from the user guide, there are two name fields that a property takes in:

  1. Property name
  2. Owner name

Both names follow the same validation protocols.

Duplicate status (if any):

--