nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Overzealous Phone Number Validation #5779

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

image.png

As the target user is "tech leads" and not "teach leads based for companies based in Singapore", the validation of only 8 digits long phone number is inappropriate, as numbers from other parts of the world do not consist of exactly 8 digits


[original: nus-cs2103-AY2223S1/pe-interim#5772] [original labels: severity.Medium type.FunctionalityBug]

TJun-Jie commented 1 year ago

Team's Response

As of right now, it is rather difficult to implement a differentiation of phone number by countries. It is possible to have 2 same phone number from 2 different countries so for now, we restrict it to just Singapore phone numbers. In future implementation, we will implement country code tagging to the phone number to fix this issue.

Duplicate status (if any):

--