search

nus-cs2103-AY2223S1 / pe-dev-response

0 stars 0 forks source link

Editing the reminders.json file to have an invalid date does not notify the user #589

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Edit 'reminders.json' to have an invalid date as shown below.

From the UG, "If your changes to the data file makes its format invalid, Rapportbook will discard all data and start with an empty data file at the next run." But it is not at all clear that edits to 'reminders.json' will only invalidate the data for reminders and not for all the data including client data.

Why should the user be notified of any parsing errors in reminders.json, or why should any parsing errors from reminders.json invalidate all data? Because the user will continue to use the app as expected. If there are many reminders, and if just one of them has an invalid date but is a really important reminder, the user will not realise that this important reminder is missing.

image.png

[original: nus-cs2103-AY2223S1/pe-interim#519] [original labels: type.FeatureFlaw severity.Medium]

kelvinou01 commented 1 year ago

Team's Response

Good catch, however, it is very rare that a user would dig into the data files and modify it to become an invalid value.

Only advanced users would modify the data files, and advanced users should know what they are doing.

Duplicate status (if any):

--