search

nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

What happens after branch merge with master #223

Closed seadragon2000341 closed 1 year ago

seadragon2000341 commented 1 year ago

Based on the forking workflow, we do our work on a branch, push to fork and then merge with master branch on upstream. So after we do all these, do we still need to keep the branch in our local repo/origin?

damithc commented 1 year ago

@seadragon2000341 While it is common practice to delete a branch after merging it, we require you to keep those branches in the team repo so that our scripts can confirm that you used branches when adding changes.

francisyzy commented 1 year ago

I have deleted some branches in my own tP fork, should I recreate it?

damithc commented 1 year ago

I have deleted some branches in my own tP fork, should I recreate it?

@francisyzy Should be fine, provided you don't delete branches used for future PRs.

nus-se-bot commented 1 year ago

@seadragon2000341 A gentle reminder to close this issue if the problem has been resolved. If not resolved yet, please post a comment explaining which part of the problem/question remains unresolved.

Hikoya commented 1 year ago

Hello @seadragon2000341 , I am a senior from the previous batch. Is there any other updates to the issue? If prof has managed to answer your question, please remember to close the issue :), else do update the post if needed.