search

nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

Testing of UI for JavaFX #240

Closed angjunkang closed 1 year ago

angjunkang commented 1 year ago

I have managed to done up some UI using JavaFX and it appears that codecov requires me to test those codes. I check the test files given in AB3 and it seems like they did not test much of the UI to begin with. Does anyone have any advice on how to work on this?

damithc commented 1 year ago

@Irminrics You can ignore the Codecov requirement for code that you decide not to have automated tests for. AB3 does not have automated tests for the GUI. Some background: AB4 has automated GUI tests (written using the TestFX library) and was used as the base repository for CS2103/T sometime back. But we found it is too much effort for students to maintain GUI tests. So we switched to using AB3 instead (one main difference between AB3 and AB4 is the automated GUI tests).

angjunkang commented 1 year ago

@damithc Thanks for the prompt reply prof! However, the codecov cause the CI status to fail in my PR, and according to the tp workflow given to us, we are not supposed to merge any failed CI into the master branch? Is there any workaround for this?

damithc commented 1 year ago

@Irminrics You can make an exception to that rule when circumstances justify it. An admin user can merge a PR even when CI is failing.

angjunkang commented 1 year ago

Got it! Thanks prof :)