search

nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

CodeCov/patch/project #251

Open junlee1991 opened 1 year ago

junlee1991 commented 1 year ago

i'm checking the PR: https://github.com/nus-cs2103-AY2223S2/tp/pull/69

image

Any hints how to make the codeCov/project / patch turn into a green tick?

The logs say Added lines #L93 - L94 were not covered by tests. any way to suppress warning?

damithc commented 1 year ago

@junlee1991 The reason is the code coverage is lower than before. You can turn it green by increasing the code coverage. But it is not a requirement from our side to do so (i.e., the coverage level does not affect the grade directly). Also see #246

tituswe commented 1 year ago

@damithc Hi prof, in the original version of AB3 that all the teams forked, the UI component was not covered by tests (i.e. the controller classes such as MainWindow.java). I made changes to MainWindow.java and now I start getting warnings by codecov that the methods in that class is not covered by tests.

Is it possible for us to suppress the warnings where appropriate? Or do we just ignore the codecov?

I have also started a new issue on testing GUI to discuss this question in detail.

damithc commented 1 year ago

Is it possible for us to suppress the warnings where appropriate?

@tituswe Yes, you are free to use CodeCov as you see fit, or not use it at all. Using CodeCov is not a tP requirement.

nus-se-bot commented 1 year ago

@junlee1991 A gentle reminder to close this issue if the problem has been resolved. If not resolved yet, please post a comment explaining which part of the problem/question remains unresolved.