nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

OK to merge PRs if Codecov is failing? #257

Open damithc opened 1 year ago

damithc commented 1 year ago

[posting on behalf of a student]

Question: For the tP my group would like to make AB3's prefixes optional (ie. all prefixes except n/ in the command line to be optional), however in doing so our code coverage fails as this results in some tests failing. One way we've been trying to work around it is to add more tests of our own (to make up for the deleted tests) however we're afraid we will not be able to sort this out by the tutorial unless we approve this PR with failing code coverage tests (due to lack of tests). Is this okay for the time being?

Answer: Yes, you may merge PRs that lower the code coverage. Also see the following: