search

nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

Red `DG Draft` task on tp progress dashboard despite updating DG b4 lecture #280

Closed EvitanRelta closed 1 year ago

EvitanRelta commented 1 year ago

My DG Draft task in my tp progress dashboard is red:

image

Despite add lines in our DG at commit https://github.com/AY2223S2-CS2103T-W12-2/tp/commit/882389b3788fb8d42755a2b1de2255aae9392f9e, which was done at Mar 24, 2023, 1:39 PM, before the 2pm Friday lecture.

Since there's no specified deadline the DG updating task (as shown below), I assume the harddeadline was Mar 24, 2pm right?

image

damithc commented 1 year ago

Since there's no specified deadline the DG updating task (as shown below), I assume the harddeadline was Mar 24, 2pm right?

@EvitanRelta Yes, that's correct.

Despite add lines in our DG at commit AY2223S2-CS2103T-W12-2/tp@882389b, which was done at Mar 24, 2023, 1:39 PM, before the 2pm Friday lecture.

@EvitanRelta Was this commit already merged to the master branch by the deadline? Only commits in the master branch are checked by our scripts.

EvitanRelta commented 1 year ago

@EvitanRelta Was this commit already merged to the master branch by the deadline? Only commits in the master branch are checked by our scripts.

@damithc Yup! Here's the Git graph of our tp's repo (ie. upstream remote not my fork). The DG-update commit and merge commit are highlighted:

image

damithc commented 1 year ago

@EvitanRelta It looks like the authorship of that part of the DG was later taken over by a different member of your team, in https://github.com/AY2223S2-CS2103T-W12-2/tp/commit/5a7a895a6f19842dd873d8283a5a2299482396be

See https://nus-cs2103-ay2223s2.github.io/website/admin/tools.html#tool-reposense-for-authorship-tracking on how to override the auto-detected authorship

On a related note, the DG Draft deliverable in week 10 is meant to get you familiarized with updating the 'Design' section of the DG, and PlantUML in particular -- so that you get an early estimation of how much effort that takes. The commit https://github.com/AY2223S2-CS2103T-W12-2/tp/commit/882389b3788fb8d42755a2b1de2255aae9392f9e doesn't match the spirit of that intention, although the dashboard script doesn't check for that specifically.

EvitanRelta commented 1 year ago

See https://nus-cs2103-ay2223s2.github.io/website/admin/tools.html#tool-reposense-for-authorship-tracking on how to override the auto-detected authorship

But will adding @@author tags after the deadline allow the time sensitive DG Draft tag to detect it though?

damithc commented 1 year ago

But will adding @@author tags after the deadline allow the time sensitive DG Draft tag to detect it though?

@EvitanRelta Yes, it should be able to detect it. If not detected 24 hours after the updated code is merged, let me know so that I can look into.

damithc commented 1 year ago

@EvitanRelta Also, it's not so important to turn this one item to green. A few red items should not affect your tP marks, unless you have many red items (i.e., less than 60% green items). The dashboard is mainly for you to track your own progress.