search

nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

Default window size #290

Closed CarrieLi1015 closed 1 year ago

CarrieLi1015 commented 1 year ago

Hello prof and peers. May I ask if it is ok for us to adjust the DEFAULT_HEIGHT and DEFAULT_WIDTH under the GuiSettings?

damithc commented 1 year ago

@CarrieLi1015 The module doesn't have any restrictions on this. So, it's a question of whether that is a good behavior for the product. Perhaps give more specifics? Are you suggesting to automatically set the window size to a specific dimension when the application is launched?

CarrieLi1015 commented 1 year ago

Thank you for your reply prof! The application window size is adjustable, but still we need to set a reasonable minima height and width (cannot be too large) as people using different sizes laptop. Which means, it might be the best if we could detect the screen size when the application is launched, and set application size based on that?

damithc commented 1 year ago

Which means, it might be the best if we could detect the screen size when the application is launched, and set application size based on that?

@CarrieLi1015 No objections to doing so. Also note that AB3 already 'remembers' the previous Window size the next time it is used. So, if the user adjusts the size, the adjusted size will be used next time.

CarrieLi1015 commented 1 year ago

Noted! Thank you so much prof!