search

nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

Making minor Ui change to fix a bug #317

Closed EvitanRelta closed 1 year ago

EvitanRelta commented 1 year ago

We have a command remark INDEX which opens a popup for user to edit the "remark" field of the Person.
However, while the popup is open, the user can still type commands, which can cause unexpected behaviour, as shown below:

able to enter command while popup

While this is clearly a bug (not a flaw), the fix we're planning is to disable the command line inputbox while the popup is open (which is a Ui change).

Is it allowed?

damithc commented 1 year ago

@EvitanRelta Looks like the feature design currently does not block certain user behaviors that can cause problems. If the user behaves as intended, everything is fine. Based on the strict definition of bugs that we use for the feature freeze, this is not a bug but a design flaw. Examples of bugs in this context: the pop up not showing up when it should, the content of the edited remark not being saved as intended.

Hence, you can update the UG to warn users not to edit the command while performing this particular task. You can also include it as a planned enhancement so that you will not be penalized for it in the PE.