nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

Feature Flaw or Bug? #344

Closed joytqt-1202 closed 1 year ago

joytqt-1202 commented 1 year ago

I have an unmark command that works for multiple objects as well as single events.

Upon further testing, it was realised that the error output is not the same...

For Single Events unmark vid on an already unmarked vid would let the user know that no changes were made because the video was already unmarked

For Multiple Events unmark vid1, vid2 when vid1 or vid2 or both are already unmarked would tell the user that the command was successful (which technically is not wrong)

For its opposite command mark mark vid and mark vid1, vid2 will let the user know that the videos were already marked

Question Is the issue for unmark on multiple events considered a feature flaw or a bug? Can I fix it in this iteration?

Thanks!

damithc commented 1 year ago

@joytqt-1202 As the current behavior is not incorrect (although can be fine tuned further), this is not a bug allowed to fix during the feature freeze.

joytqt-1202 commented 1 year ago

okay! thank you!