search

nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

Sequence diagram's exit arrow points to the right #379

Open EvitanRelta opened 1 year ago

EvitanRelta commented 1 year ago

One of our reported bug states that our sequence diagram's last arrow set user input to "add t/tag1" should point to the left (ie. where the entry arrow comes from). Is he correct? Or is exiting on the right ok?

image.png

toh-xinyi commented 1 year ago

I'm not entirely sure, but I think the tester would be right in this case as pointing to the right would make it seem like the sequence diagram has not ended. And since the invocation comes from the left, returning towards that direction would make the most sense. Like the following diagram taken from the textbook: image

EvitanRelta commented 1 year ago

alright. What should the severity be for this tho? Is it very low, as its cosmetic and its unlikely for users to misunderstand?

damithc commented 1 year ago

alright. What should the severity be for this tho? Is it very low, as its cosmetic and its unlikely for users to misunderstand?

The teaching team leaves the decision to you, but others are welcome to chime in their opinions.