nus-cs2103-AY2223S2 / forum

12 stars 0 forks source link

tp dashboard not showing attributes #437

Closed jinnieshin closed 1 year ago

jinnieshin commented 1 year ago

Hi prof, I have done v1.1 PRs, v1.2 PRs and PPP Draft but was not captured on the dashboard. I would appreciate if the commitment is considered.

damithc commented 1 year ago

@jinnieshin
PRs need to follow the forking workflow to be counted. The ones you have cited come from the master branch of your fork, which means they don't follow the for forking workflow fully. PPP Draft is a time-sensitive deliverable, which means it needs to be done within the week it appears. I did not check this but I suspect that is why it doesn't appear in the dashboard. If not, let me know so that I can look into it further.

jinnieshin commented 1 year ago

Oh I see, may I ask whether there would be anything I can do to include it into the dashboard? Should I add equivalent tags in the fork?

damithc commented 1 year ago

Oh I see, may I ask whether there would be anything I can do to include it into the dashboard? Should I add equivalent tags in the fork?

Not at this time. But having a few red items in the dashboard shouldn't affect marks, unless you have many red items.

jinnieshin commented 1 year ago

Okay. Thank you for answering!