nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Able to add duplicate tags for a module #1104

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Steps to reproduce

  1. Add a module with module code add /m CS1101S /c 4 /y Y1S1
  2. Add a tag to the module tag CS1101S include /t CSF
  3. Add the same tag to the module by repeating the command in step 2

Expected:

Actual

Screenshot 2023-04-14 at 2.38.42 PM.png


[original: nus-cs2103-AY2223S2/pe-interim#938] [original labels: severity.Low type.FunctionalityBug]

cjyothika commented 1 year ago

Team's Response

By "Added" we meant that the tag either already exists or has been added if it did not already exists. If you look at the modules in the module list and the degree progress, there are no tags that are duplicated. The typical user would not require double tagging a module with the same requirement either. Therefore, it does not affect the functionality of the app and it is more of a semantics or clarity of language issue. Also, if we did include an error message for adding existing tags to modules, we might issue errors when there are a lot of valid tags with 1 duplicate tag added in one command, causing the user to have to re-type the whole command when it is not necessary. We believed that the error message is unnecessary in this case. Moreover, we did not state that this is a scenario when an error message will be displayed in the UG or DG.

However, we do agree that the clarity of the language used in the success message can be improved.

Duplicate status (if any):

--