nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Overzealous phone number handling #1413

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

It is mentioned in the UG to take the last input, so I assigned low severity to this case of overzealous phone number handling.

Steps to reproduce: add n/Tester p/+6587438807 p/99999999 e/alexyeoh@example.com a/Blk 30 Geylang Street 29, #06-40

Expected: Add person with 2 phone numbers

Actual: Only added the last phone number

For more detail, please refer to the screenshot below:

Screenshot 2023-04-14 at 2.39.22 PM.png

According to CS2103T website: Overzealous vali.png


[original: nus-cs2103-AY2223S2/pe-interim#1185] [original labels: severity.Low type.FeatureFlaw]

Merrickneo commented 1 year ago

Team's Response

We specified that for the phone placeholder, if multiple numbers are provided, only the last number will be accepted.

But this is something that we can explore in the future to allow an applicant to have multiple numbers.

Screenshot 2023-04-16 at 10.38.23 AM.png

Duplicate status (if any):

--