nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Wrong description when adding a person #1582

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Steps to Reproduce

When adding the sample command from the UG.

add n/James e/james@example.com ig/itsjameshere tg/itsjameshere mod/CS2103T mod/CS2101 cca/NUS Hackers r/Year 2 b/01/01/2000

Expected

New person added: James; Phone: ; Email: james@example.com; Birthday: January 1, 2000; Social media: Instagram: itsjameshere Telegram: itsjameshere; Address: ; Remarks: [Year 2]; Modules: [CS2103T][CS2101]; Ccas: NUS Hackers

Actual

New person added: James; Phone: Optional.empty; Email: Optional[james@example.com]; Birthday: Optional[January 1, 2000]; Social media: Optional[Instagram: itsjameshere Telegram: itsjameshere ]; Address: Optional.empty; Remarks: [Year 2]; Modules: [CS2103T][CS2101]; Ccas: NUS Hackers
Basically should not have Optional in the log and should just provide the values.

System

OS: Windows 10 Version 22H2 JDK: Azul Zulu JDK 11.60.19 (11.0.17), 64-bit Resolution: 1920 x 1080

_{[original: nus-cs2103-AY2223S2/pe-interim#2060] [original labels: severity.Low type.FunctionalityBug]}

gremmyz commented 1 year ago

Team's Response

Thank you for the feedback.

Disagree. Rejecting because it is expected output as per our UG. It is documented that there will be Optional in the log as per the screenshots. Changing this to feature flaw as it is something we can improve on to make the app catered to less technically-inclined users.

Duplicate status (if any):

--