nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Index of patients do not change when deleting someone. #2401

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

If I use patient delete 1, the first patient does indeed get removed, but the number indexes do not update to fill the gaps. If I subsequently add a new patient, this patient simply gets added to the end of the list. I am unable to test all the way to a possible upper bound for the app but this makes the app potentially hard to use in the long term.

patient list doesn't update the indexes too, but this was not mentioned anyway, just a note.

image.png


[original: nus-cs2103-AY2223S2/pe-interim#3130] [original labels: type.FunctionalityBug severity.Medium]

francisyzy commented 1 year ago

Team's Response

In the UG it is stated that the patient ID is unique.

A patient is uniquely identified by a generated PATIENT_ID. Duplicate patients are allowed in the system as there might be patients with the exact same attributes that want to be vaccinated.

If you delete PATIENT ID 1, a newly created patient should not take its ID in its place as IDs are unique.

This is a ID number, not the index number of the patient.

Duplicate status (if any):

--